Himalayan-Academy / Siva-Siva-App

Code Repository for the Siva Siva Mobile App
11 stars 3 forks source link

Fix Browser Problem view_BrowserLandscape.livecode #227

Closed Brahmanathaswami closed 3 years ago

Brahmanathaswami commented 5 years ago

1) first you have to start playing the movie 2) Then you turn the phone upright 3) the layout should fixed the landscape (it does on Android) 4) but on iOS the browser body change orientation to portrait, and to footer disappears. Not you user has no way "out" he is stuck on the app. and he must restart his phone..

5) perhaps the best solution is

Brahmanathaswami commented 5 years ago

@bwmilby More discoveries: it is not really failing on iOS when we move the phone upright (portrait) on iOS. What is happening is

SOLUTIONS:

BTW Our next big module is to provide robust access to out YouTube. We will deprecate the Look TOC and go straight to the new module (as we do with LISTEN) that why we want the browser, in landscape mode to work. If will be very important later.

bwmilby commented 5 years ago

It looks like this is going to require a change to the Browser object in LC (UIWebView). allowsInlineMediaPlayback needs to be set to TRUE for the embed option to be recognized. It defaults to TRUE on iPad, but FALSE on iPhone. I will push a change today that will fix it for iPad - not sure how an Android device will treat it though (should just get ignored).

?playsinline=1 or &playsinline=1 is what needs to be added to the end of the youtube embed URL (with the above property set).

This is the Apple dev document that I'm referencing: https://developer.apple.com/documentation/webkit/wkwebviewconfiguration/1614793-allowsinlinemediaplayback?language=objc

YouTube Player parameters: https://developers.google.com/youtube/player_parameters

Brahmanathaswami commented 5 years ago

FOR reference : https://developers.google.com/youtube/player_parameters

OK, I get it. Untll then, if you can prevent orientation change on the iPhone, for

view_BrowserLandscape.livecode

when they turn their phone upright, so it behaves like Android

that would suffice for now.

bwmilby commented 5 years ago

PR #228 partially addresses this issue. For iPad, the content will remain landscape.

Brahmanathaswami commented 5 years ago

Pending patch from LIVE Code

Brahmanathaswami commented 5 years ago

Did we create a ticket Quality Control in LC... ? I don't see a fix into 9.5 release notes

Brahmanathaswami commented 4 years ago

@bwmilby

Working on git hub issues, updating, closing etc. and making a roadmap... I believe this issue was solved in 9.6? Right?

Brahmanathaswami commented 3 years ago

good to go