Himalayan-Academy / Siva-Siva-App

Code Repository for the Siva Siva Mobile App
11 stars 3 forks source link

Listen Module - Testing Mar 26th #275

Closed Brahmanathaswami closed 3 years ago

Brahmanathaswami commented 3 years ago

1) Testing Journal:

Desktop:

Journal Entry:

image

First item in Journal success, it plays, can pause

image

Seconds item in Journal, on top show a 10 sec marker we go to "listen-file" and get no response: can not play

image
Brahmanathaswami commented 3 years ago

And BTW http calls getting no response

image
Brahmanathaswami commented 3 years ago

We are not getting "hard crash"

1) the download play; it goes at line 990 (Chunk: errpr in object expression) near "7" char 8 2) the play button takes back to the beginning

image
Brahmanathaswami commented 3 years ago

on behavior_Listen

you can (if you want to do it )


line 990 --put the long id of pTarget into sLastTarget put pTarget into sLastTarget


in group "DownloadControls" in your behavior_Download

line 157

you can delete these two lines

 -- delete word 1 to 4 of sRequestedBy
  -- comment dispatch "updateCachedListings"  to sRequestedBy with sRecordNumber

  hidedDownloadControls
  put removeQuotes(sRequestedBy) into tModule     
  tracking_RecordActivity tModule,"download/saved"

end if end downloadComplete

Brahmanathaswami commented 3 years ago

card "listen-my-audio" we get there from the header "My Downloads" screen:

card "listen-my-audio": Songs / Audio Books / Talks: should start at zero NOT the starting timestamp of the Journal. They should only start at the current timestamps from the journal be clicking journal icon / entry in the journals

  1. When go the card "listen-file" from the "My Downloads" link: timestamps should set to empty or 0
  2. When coming from "Journal" the card "listen-file" should start to the timestamp which given last by the user for journal entry.

This usage was taking into effect before you started work. Now it does not work at all. :-(

The timestamp on mobile is correct: hours | minutes | seconds. That is good :-)

Brahmanathaswami commented 3 years ago

card "listen-my-audio": the "My Downloads" on mobile field "AudioList" is currently higher to some number of pixel, that is not addressed in the updateUI

line 251: case "listen-my-audio"

# this should  be there
  put the long id of fld "audioList" into tAudioList
     set the rect of tAudioList to (10, the bottom of tCollectionsLabel + 18, \
           CardWidth() - 7, the top of tFooter - 17)
     centerMe tAudioList, 60,70
bwmilby commented 3 years ago

CenterMe shouldn’t be needed. If the rect isn’t correct, then just adjust it directly. It is being sized and positioned relative to other controls.

soapdog commented 3 years ago

I haven't touched any geometry code or changed any of the UI. I'm only working on the behaviors and other plain-text stacks.

soapdog commented 3 years ago

This usage was taking into effect before you started work. Now it does not work at all.

In issue #274, I've outlined how buggy the listen module was, be aware that that was not an exhaustive list, I've found a ton more after working that issue.

Don't blame me about the current broken state of the module. I'm still working trying to untangle it. I never claimed it to be working, what I've been saying is where it is breaking after some more work was done.

That module is a maze of confusing state management and functions that don't behave exactly like they're written — such as passing a clickline to a variable called pItemID, and then trying to fetch it from the database, or impossible if clauses that will never be met because the variables they're checking are never ever set those values.

As can be seen on my last commit message to the listen-5 branch: https://github.com/Himalayan-Academy/Siva-Siva-App/commit/9a4a97c286be0aff87b49cddd3f890e0c9ce8508

 [[ listen ]] hard crash on iOS Simulator 

The stack is broken, it is not ready for testing, it is not supposed to be working.

Brahmanathaswami commented 3 years ago

Well I did not mean to "blame" you that it's broken. I just testing in the Simulator. c9ce8508. did not "hard crash" it was going on just fine...with a few tests.

soapdog commented 3 years ago

This issue is not really actionable. All that is mentioned here is covered by other issues. Because of that, I'm closing the issue so that I can better manage each bug as it's own individual and unique issue.