Listen: possible duration bug

Himalayan-Academy / Siva-Siva-App

Code Repository for the Siva Siva Mobile App

11 stars 3 forks source link

Listen: possible duration bug #283

Closed soapdog closed 3 years ago

soapdog commented 3 years ago

THE Desktop version: we get a durattion

THE Mobile version: we see the duration show "00:00:00"

Originally posted by @Brahmanathaswami in https://github.com/Himalayan-Academy/Siva-Siva-App/issues/274#issuecomment-813468246

soapdog commented 3 years ago

This bug is not clear to me. I don't know what duration we're talking about and how the bug manifests. Is this about the current position of the track during playback? the total track duration during playback? some timestamp display on the journal?

@Brahmanathaswami please add some more context and if possible a screenshot demonstrating this bug so that I understand better what I need to fix.

Brahmanathaswami commented 3 years ago

it is only the Mobile Version

Here is a picture from my iPhone

soapdog commented 3 years ago

Okay! Thanks for the explanation, working on it.

soapdog commented 3 years ago

I'm having a hard time reproducing this because it is working fine on my android device.

photo_2021-04-07 12 34 05

I suspect that a number of things are happening:

All the URLs in the app need to be https:// which they were not. Apple requires the usage of secure URLs.
The URLs used by the app are not whitelisted in the standalone application settings.
The app makes a bunch of requests when it launches and when the listen module launches. I suspect that later requests are failing not because there is no network access but because the previous requests have not completed. The code never checks for this option and assumes the requests will only fail if the network fails, which is not true.

soapdog commented 3 years ago

I've pushed an update just changing the URLs to be HTTPS. I can't reproduce this bug and since there is no difference in the code between Android and iOS this is probably a LC engine bug regarding mobileControlGet('audioplayer','duration') in iOS.

Brahmanathaswami commented 3 years ago

https://github.com/Himalayan-Academy/Siva-Siva-App/issues/288

put mobileControlGet("audioPlayer","playableDuration") into sDuration

     We heard from Elanor.