search

Himalayan-Academy / khm-virtual-tour

Kaua'i Hindu Monastery Virtual Tour web application
0 stars 0 forks source link

Gallery Broken #19

Closed JaiNatha closed 5 years ago

JaiNatha commented 5 years ago

As mentioned before in an email, the Galleries page isn't loading, or rather its trying to load everything..

soapdog commented 5 years ago

The gallery tries to load everything. It was failing because the drag & drop in the map was buggy and was breaking the JSON files of the dragged pins, basically, it was saving the position correctly but it was erasing other metadata such as title and others. This caused the gallery to fail as it needs that data.

I've fixed that and now the gallery loads, but it still tries to load all items in the same page. Would a different UI be better? Maybe pagination? What do you think @JaiNatha ?

JaiNatha commented 5 years ago

Yes, pagination would be a good way to go

JaiNatha commented 5 years ago

Also, do you think we could make the images in the Gallery all uniform height and width. Obviously would require cropping, or possibly we could choose only landscape images for whatever shows up in the gallery

soapdog commented 5 years ago

It is better if we just select landscape images as heroes. I'm building this pagination now, it might take a while to get it right.

soapdog commented 5 years ago

@JaiNatha added the pagination to the galleries page.

JaiNatha commented 5 years ago

Is no longer loading for me. Just sits there and spins..

soapdog commented 5 years ago

The JSON for the Palm Corridor was broken and was causing the app to crash. There was an illegal unicode character in it.

soapdog commented 5 years ago

Just added a little extra check to the backend to make sure that if the json is broken, that we don't break the whole app.

@JaiNatha can you check it now? 😉 (forgot to tag you here when I solved this last week)

JaiNatha commented 5 years ago

yup it works