Issue86 functional theme change button

[ANSH127]

add a feature to toggle the theme

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/97f7ce18-d546-4216-adc0-34096fed2334

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
career-zunction	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 19, 2024 9:19am

[HimanshuNarware]

@ANSH127 RESOLVE CONFLICTS

[ANSH127]

@HimanshuNarware Done

[HimanshuNarware]

@ANSH127 light theme has lots of problems like the font are not visible clearly. also internship section need improvement

[HimanshuNarware]

add a feature to toggle the theme

CareerZunction.-.Google.Chrome.2024-05-13.16-15-35.mp4 like you show in video font are not that in color

[ANSH127]

@HimanshuNarware let me fix the font issue and tell me in light theme what changes you want. in internship page?

[ANSH127]

@HimanshuNarware

could I make the card bg light black?

[ANSH127]

I fixed the font issue and changed the bg color of the card

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/b4fdee9a-25ce-4582-b9be-79adcee9b6ce

[HimanshuNarware]

@ANSH127 footer section text is not visible

[ANSH127]

@HimanshuNarware Now is it ok?

[ANSH127]

done

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/8a86d2a4-ed41-41a4-ad10-2f4d17647414

[ANSH127]

@HimanshuNarware

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/9f9d1ee8-c05a-43a2-8acc-3fcf724f385b

[PSS2134]

Can you make hover effect in light theme to dark purple not black @ANSH127 ? You have changed theme at internship section to black, it was dark purple can you revert that , and check whether it is applied to other sections also for dark mode

[ANSH127]

@PSS2134 okay sure

[ANSH127]

@PSS2134 done

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/36e84723-25f6-466b-a70b-ddb950f4f076

[PSS2134]

In the Internship section, for light theme, the cards look too bright at borders, also the footer is not distinguishable , may be you can add a light grey line or something and keep the default theme to dark, when someone opens the site @ANSH127

[ANSH127]

@PSS2134 I have set the border gray on the light theme , distinguished the footer, and set by default the dark theme

https://github.com/HimanshuNarware/CareerZunction_Intern/assets/119344874/8c423a38-10af-4776-853c-1b078f860c19

[PSS2134]

Still looks bright and can't see gray line at the footer can you check @ANSH127 , Also resolve conflicts after changes

[HimanshuNarware]

@ANSH127 are you still working on this issue.

[HimanshuNarware]

@ANSH127 for the light theme use a black background on the card, but for the dark it is the same

[HimanshuNarware]

@HimanshuNarware

could I make the card bg light black?

@ANSH127 only for the light theme , dark theme remain same

[HimanshuNarware]

@ANSH127 Do one thing again raise PR with recommended changes