HimanshuNarware / CareerZunction_Intern

CareerZunction, an open-source platform, offers 200+ internships. Its user-friendly interface enables students to access career resources and foster professional growth. By connecting students with diverse opportunities, it empowers them in their career journeys. Testing Link-> https://career-zunction-intern-testing.vercel.app/
https://career-zunction.vercel.app
97 stars 132 forks source link

Adding a search bar for company names and work mode-based filter option #211

Closed MitashaJ closed 3 weeks ago

MitashaJ commented 1 month ago

[Feature Request]: Adding a search bar for company names and work mode-based filter option #197

A search bar has been added to the top of the internship page. It can be used to search internships based on Company name and Internship name both. image

A Filter feature is added at the right side of the search bar . It can be used to filter results based on the mode of work-online, offline, hybrid. (default-All modes)

image

Fuzzy search functionality has been added and a threshold value set to 0.3 for a balanced level of fuzziness. image

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
career-zunction ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 9:15am
career-zunction-intern-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2024 9:15am
MitashaJ commented 1 month ago

[Feature Request]: Adding a search bar for company names and work mode-based filter option https://github.com/HimanshuNarware/CareerZunction_Intern/issues/197

Fuzzy search functionality has been added and a threshold value set to 0.3 for a balanced level of fuzziness. @Shubh942

MitashaJ commented 1 month ago

@PSS2134 I have fixed footer issue for 'No results' and updated border colour of search bar, filter.

image

image

The pagination currently doesn't display the default 12 internships as expected. As for search, it need to search through all internships, not just those on the current page. To fix this, pagination logic is needed to adjust. So should I change pagination logic or leave it be?

MitashaJ commented 1 month ago

The pagination issue has been fixed. Now, by default, 12 internships are shown. When using the search or filter functions, the maximum number of internships shown is also limited to 12.

@PSS2134 u can now review it and also can u add labels to this PR ?

image

image

Shubh942 commented 1 month ago

@HimanshuNarware review this pr. Looks good to me.

MitashaJ commented 1 month ago

I have made the page responsive. @PSS2134

WhatsApp Image 2024-05-29 at 14 40 01_ff2b0e3f

WhatsApp Image 2024-05-29 at 14 40 32_190cdd34

MitashaJ commented 1 month ago

@PSS2134 Can you review and tell me if any other changes are required

Shubh942 commented 1 month ago

@PSS2134 @HimanshuNarware looks good.

PSS2134 commented 3 weeks ago

@MitashaJ Everything looks good, just the work based dropdown looks large for mobile devices, Then I would be happy to merge

MitashaJ commented 3 weeks ago

@HimanshuNarware can you just add lables to this PR ?