Closed MitashaJ closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
career-zunction | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2024 9:15am |
career-zunction-intern-testing | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2024 9:15am |
[Feature Request]: Adding a search bar for company names and work mode-based filter option https://github.com/HimanshuNarware/CareerZunction_Intern/issues/197
Fuzzy search functionality has been added and a threshold value set to 0.3 for a balanced level of fuzziness. @Shubh942
@PSS2134 I have fixed footer issue for 'No results' and updated border colour of search bar, filter.
The pagination currently doesn't display the default 12 internships as expected. As for search, it need to search through all internships, not just those on the current page. To fix this, pagination logic is needed to adjust. So should I change pagination logic or leave it be?
The pagination issue has been fixed. Now, by default, 12 internships are shown. When using the search or filter functions, the maximum number of internships shown is also limited to 12.
@PSS2134 u can now review it and also can u add labels to this PR ?
@HimanshuNarware review this pr. Looks good to me.
I have made the page responsive. @PSS2134
@PSS2134 Can you review and tell me if any other changes are required
@PSS2134 @HimanshuNarware looks good.
@MitashaJ Everything looks good, just the work based dropdown looks large for mobile devices, Then I would be happy to merge
@HimanshuNarware can you just add lables to this PR ?
[Feature Request]: Adding a search bar for company names and work mode-based filter option #197
A search bar has been added to the top of the internship page. It can be used to search internships based on Company name and Internship name both.![image](https://github.com/HimanshuNarware/CareerZunction_Intern/assets/128090631/5773aa61-8e4e-401d-b62d-908adb9cbc06)
A Filter feature is added at the right side of the search bar . It can be used to filter results based on the mode of work-online, offline, hybrid. (default-All modes)
Fuzzy search functionality has been added and a threshold value set to 0.3 for a balanced level of fuzziness.![image](https://github.com/HimanshuNarware/CareerZunction_Intern/assets/128090631/d3de03c4-d6c3-481d-b6a2-33e95c5abe1e)