Bug with save skins with skins from Markedplace

[galaxytwenty]

For example the wandering trader!

This is the skin it looks when im joining in to the server:

This is the skin it looks when im runnin /skin save and then /skin load:

And this is the saved skin texture from plugin_data:

This is only with some skins from markedplace, and not with downloaded skins.

[galaxytwenty]

Screenshot from this content from markedplace:

[HimbeersaftLP]

Hmmm, I think this might be due to the geometry data?

[galaxytwenty]

I dont think so, if i save the geo and set the geo when load skin ... its exactly the same..

aaand he save the skin wrong in .png

[HimbeersaftLP]

can you send me the player.dat file so i can look at the raw skin data?

[HimbeersaftLP]

(the player.dat file before overwriting with the wrong skin using my library ofc)

[galaxytwenty]

Sure i can send when im home,You mean the Player.dat after joining with the skin, before i run save and load , right?

[galaxytwenty]

can i send via DC?

[HimbeersaftLP]

yes exactly and I think you can upload it right here on github

[galaxytwenty]

sure, i can try uploading here.

[galaxytwenty]

must ziping the .dat... GH say we dont support that file type

[galaxytwenty]

glx20.zip

[galaxytwenty]

there is the player.dat directly after joinen with the wandering trader skin

[HimbeersaftLP]

Thanks, I'll take a look at it

[galaxytwenty]

np, hopefully it can be fixed :)

[galaxytwenty]

have you found any points in these file ?

[HimbeersaftLP]

Sorry I didn't have time, yet

[HimbeersaftLP]

Hello, I found the problem.

You will need to save and restore both the geometry and the geometry name.

As an example, I updated the example plugin like this to include that change: https://github.com/HimbeersaftLP/LibSkin/commit/4f1a9369fbd737b09e2a9e88d981cad03916836e#diff-fdfadedddd0afa2f4f19afd620913f573521b6d7ed08a168b8bcd376b2b82594

[HimbeersaftLP]

@galaxytwenty Please let my know if this fix works for you as well

[galaxytwenty]

Of course, i testing this when im home.I let you know. Thanks

[galaxytwenty]

Thats work´s fine now. Best Thanks :)

[HimbeersaftLP]

You're welcome!

[HimbeersaftLP]

Thanks for testing it

[galaxytwenty]

Thanks for i can use it 👍