search

HimbeersaftLP / SpoonCreator

Adding spoon features to PocketMine to create your 102% unique (totally legit) spoon is now as easy as running a script on Linux!
GNU General Public License v3.0
7 stars 2 forks source link

Fix plugin commands #3

Open NiekertDev opened 7 years ago

HimbeersaftLP commented 7 years ago

Uhm, have you tested this?

  1. It looks like you are replacing "string $label" with "label" (see the missing $?)
  2. The :bool is still there
  3. Doesn't that have to be done is PluginBase too?
  4. Why not just revert this commit: https://github.com/pmmp/PocketMine-MP/commit/46a2e6cbf8f1fd71e632b1d3b4ccc34492683721
NiekertDev commented 7 years ago
  1. Fixed
  2. Doesn't matter right, commands always return false/true
  3. Where!?
  4. Idk how to do xD
HimbeersaftLP commented 7 years ago
  1. Oke
  2. I've reading from many people that don't do that
  3. See the linked commit in my post above
  4. git revert
NiekertDev commented 7 years ago

idk then