search

HimbeerserverDE / mt-multiserver-proxy

mt-multiserver-proxy is a reverse proxy designed for linking multiple Minetest servers together
MIT License
27 stars 6 forks source link

Docker container #132

Closed AFCMS closed 9 months ago

AFCMS commented 11 months ago

Currently you can only build and run the proxy from your main Go installation.

I am used to deploy my Minetest servers with Docker Compose which helps a lot to track regressions (with git bisect in the configuration repository which includes mods as submodules).

I would really like if there was a way to use this proxy from Docker. The biggest problem is the way to handle plugins.

HimbeerserverDE commented 11 months ago

I agree, Docker support should be added.

How would plugins be loaded though? A volume should work but I'm not sure if it's the best solution.

I'm going to start working on this soon but I'm not too experienced with Docker. I'll link a PR once it's ready and would be glad if you reviewed it.

AFCMS commented 11 months ago

I would be happy to review if you start working on Docker support.

HimbeerserverDE commented 11 months ago

As you can see the PR is ready and can be reviewed.

As for plugins, you'll probably want to look into auto builds: Cloning the source code into the plugins directory using git submodules should work well.

AFCMS commented 11 months ago

Will try to review as soon as possible, too busy rn.

HimbeerserverDE commented 9 months ago

I'd like to get this merged before updating to 5.8 so that it's available to 5.7 users. Do you still want to review it? If not (or if it would take a long time), would it be okay to merge the PR for now and address any problems later in a new issue?

AFCMS commented 9 months ago

You just reminded me of it, will try to do that today. 🙂