Roguedeus
commented
8 years ago Is this an adequate benchmark? Do you see any inconsistencies? (I went a bit overboard on the class constructor though)
require "benchmark"
TIMES = 50
DATA = {}
def class_constructor(suffix)
eval(
"
class Data_#{suffix}
attr_reader :hp
attr_reader :mp
attr_reader :atk
attr_reader :def
attr_reader :mat
attr_reader :mdf
def initialize
@hp = rand(TIMES) + 1
@mp = rand(TIMES) + 1
@atk = rand(TIMES) + 1
@def = rand(TIMES) + 1
@mat = rand(TIMES) + 1
@mdf = rand(TIMES) + 1
end
end
DATA[#{suffix}] = Data_#{suffix}.new
"
)
end
x = 0
TIMES.times {class_constructor(x); x+=1} #Builds TIMES number of Data objects.
$rebuild = false
class Test
def data(var)
DATA.inject(0) {|x,(key,val)| x + val.method(var).call }
end
def data_cached(var)
return @data_cached if @prev_var == var && !$rebuild
@prev_var = var
$rebuild = false
@data_cached = DATA.inject(0) {|x,(key,val)| x + val.method(var).call }
return @data_cached
end
end
TIMES1 = 100000
x = 0
REBUILD_CHANCE = 0.25
obj = Test.new
Benchmark.bm(30) do |b|
#----------------------------------------------
b.report "Rebuild" do
TIMES1.times do
$rebuild = true if rand < REBUILD_CHANCE
x = obj.data(:hp)
end
print("#{x}")
end
#----------------------------------------------
b.report "Cached" do
TIMES1.times do
$rebuild = true if rand < REBUILD_CHANCE
x = obj.data_cached(:hp)
end
print("#{x}")
end
end
=begin
user system total real
Rebuild 1322 3.089000 0.000000 3.089000 ( 3.085176)
Cached 1322 0.811000 0.000000 0.811000 ( 0.812047)
[Finished in 4.1s]
=end
HimeWorks
We have Element Damage... And
UsableItemEffects, like add state, etc... But nothing combined.What if, a stun wasn't just a stun, but an ICE stun? All rates are effected first by element resistance, and then by effect resistance. Thus a target 50% resistance to ICE, and 50% Resistance to Stun, has a 25% total resistance against ICE Stun.
This is just a simple example. But it would make certain effects able to be applied much more liberally, when something Immune to an element, is by extension also immune to all that elements linked effects.
Meanwhile, an EARTH Stun, will work fine... etc.
Elements are purely cosmetic. It would be linked to element ID's and thus can be easily extended.
Now... How would the easiest way to implement it be?
If the effect is a state, the note tag could be on that state... But then, it would require every state of every element to be individually defined. What if the link were made on the
UsableItem?Thus, only one state is needed, and can be applied under different circumstances. Kind of like conditional effects.