search

Himujjal / tree-sitter-svelte

Tree sitter grammar for Svelte
MIT License
77 stars 15 forks source link

Atom compatible version #22

Closed rixo closed 2 years ago

rixo commented 2 years ago

Hey! I'm considering using this package for syntax highlighting in an Atom plugin.

Everything seems pretty good, except that the current stable Atom only supports ABI up to 12, and the version this package is using is producing ABI 13.

Some experimentation reveals that building this package with tree-sitter-cli v0.17.x, without changing anything else, gives us a package that can be used (for good effect!) in current Atom.

I wondered if there was a possibility, somehow, for this package to publish ABI 12 versions. I'm not sure what are all the consumers of this package, but maybe downgrading this package to tree-sitter-cli 0.17 while waiting for Atom to catch up would be an option? (Just mentioning, I don't believe in this one that much.) Or maybe we can just fork this package on our side and publish something like tree-sitter-svelte-atom from it?

Any approach look like they would get the job done to me, in regard to the Atom use case, and I have no strong feelings either way (even if I have a hunch that having a dedicated Atom package might be the more practical).

I mainly just wanted to see with you if you had any preference or maybe suggestions for a better approach?

Oh, and thanks for the good work :) Cheers!

Himujjal commented 2 years ago

Hi. I would love this package to be used for Atom's syntax highlighting. But unfortunately I think I am not apt to answer your questions. If you wish, you can create another fork of this repo for the same. Its fine from my side for you to do anything. If any help is required in that repo, please ping me on Discord (himu#2789). Or you can simply add new comments here

I however don't really wish to dwell with the intrinsic details of any IDE or make changes for the same. This package solely focuses on the grammar.

Personally I use Neovim which supports the current version of this library pretty well.

rixo commented 2 years ago

Thanks for your answer. I think we'll fork and publish an Atom compatible version of the package then. Hopefully Atom will catch up with the last version of tree-sitter at some point!