Fix dai_link->cpus etc used without backing storage.

HinTak / seeed-voicecard

This is an enhancement fork with the explicit aim of supporting current shipping Raspbian/Ubuntu kernels without requiring downgrading. Please donate at https://hintak.github.io/ if it works for you. Use vX.Y branch for kernel version vX.Y

GNU General Public License v3.0

180 stars 67 forks source link

Fix dai_link->cpus etc used without backing storage. #3

Closed rotdrop closed 3 years ago

rotdrop commented 3 years ago

Ok, this is for v5.5. But I believe the problem is also present in the master and other branches. Commit 37a37a6 moved to "modern style dai_link". However, for doing so adi_link->cpus etc. needs to be provided with backing storage. This is not done automatically, at least not in 5.4. Please compare KERNEL/sound/soc/generic/simple-card-utils.c, function asoc_simple_init_priv(). Without this patch module loading immediately result in NULL-pointer dereference.

HinTak commented 3 years ago

Thanks. I'll find time to look at this properly.

HinTak commented 3 years ago

I am not convinced this is completely correct, and I think it is partly the answer, or a good step towards it.