search

HinTak / seeed-voicecard

This is an enhancement fork with the explicit aim of supporting current shipping Raspbian/Ubuntu kernels without requiring downgrading. Please donate at https://hintak.github.io/ if it works for you. Use vX.Y branch for kernel version vX.Y
GNU General Public License v3.0
196 stars 73 forks source link

fix detection of kernel modules on 64-bit image #7

Closed hellow554 closed 1 year ago

hellow554 commented 1 year ago

The lib modules folder looks like /lib/modules/6.1.21-v8+/build, which means that the previous regex doesn't capture anything after the - and therefore it fails to detect the kernel version. The regex now aligns with the other detection method and this works fine on my machine™

HinTak commented 1 year ago

Thanks for working on this. Looking at it, I rather think the correct answer is "^\/", don't you think so?

hellow554 commented 1 year ago

I just used what's already there ;) I can change both if you like

HinTak commented 1 year ago

Yes, please (and some minimal testing too...). Thanks a lot.

HinTak commented 1 year ago

Argh, hang on, is this 64-bit kernel on 32-bit userland or 64-bit on 64-bit? The former does not work yet (upstream problem, missing kernel headers). I assume it is the latter as you have gotten it working?

hellow554 commented 1 year ago

64-bit on 64-bit

yes, it was that one. I got it working after doing this fix ;)

I currently don't have hardware to test on, so that's the best I can do

uelpenich commented 1 year ago

Thanks for working on this. Looking at it, I rather think the correct answer is "^/", don't you think so?

Works for me, please insert this correction into the install.sh

(Debian Bullseye 6.12.1-v8+, 64bit Kernel 64Bit User)

HinTak commented 1 year ago

Thanks for testing. I have merged this but will also put the result of the discussion in after the merge.

uelpenich commented 1 year ago

Thanks for merging fast.

This is my working configuration:

Hardware: Raspberry Pi 4 with 4GByte memory, ReSpeaker 4 mic array

OS: Raspberry Pi OS with desktop, Image 2023-05-03-raspios-bullseye-arm64.img

Raspberry Pi configuration: Interfaces SSH, VNC, SPI, I2C

PulseAudio issue: due to the Taskbar plugin problem with lxplug-volumepuls I removed it: refer to https://forums.raspberrypi.com/viewtopic.php?t=293630#p1774697

sudo apt purge lxplug-volumepulse

You may install the Alsa plugin instead:

sudo apt install lxplug-volume

Install seeed-voicecard:

git clone https://github.com/HinTak/seeed-voicecard cd seeed-voicecard sudo ./install.sh sudo reboot

You may use Audacity to show seeed-voicecard working (2 channels only):

sudo apt install audacity -y

Suggestion to @HinTak Change in Install seeed-voicecard section the line git clone https://github.com/respeaker/seeed-voicecard to git clone https://github.com/HinTak/seeed-voicecard

Thank you for your work

HinTak commented 1 year ago

Thanks. I have updated to URL now (only on the tip, v.6.3/v6.4). The volume control related crash seems to be quite well-known. I read that most just recommend removing the plug-in. Good you have found an answer without removing it completely.