search

Hinaser / gfm-advanced

GitHub Flavored Markdown Editor plugin for IntelliJ compatible IDEs.
https://plugins.jetbrains.com/plugin/14683-gfma
MIT License
17 stars 1 forks source link

Does not fully support UTF-8 emojis #5

Closed SpraxDev closed 3 years ago

SpraxDev commented 3 years ago

Hey! Just downloaded your plugin and realized that some UTF-8 emojis are rendered wrong. e.g. 🎨 or 🌍

Screenshot

WebStorm: 2020.2.3 GfmA: 0.0.3

Hinaser commented 3 years ago

Sorry for late, but I confirmed this issue. I'll see to it.

Hinaser commented 3 years ago

Memo

Looks like the issue is in GetStringUTFChars() at JNI, which converts Java portion of String data to C++ portion of char* value.

References

https://bitbucket.org/search?q=repo%3Ajava-cef%20executeJavascript&account=%7Bdc443723-7652-4c63-b340-033e522146db%7D https://bitbucket.org/chromiumembedded/java-cef/src/304f3e3de03fb3aab5e8212c0f9c699503a55cb4/native/CefBrowser_N.cpp?at=master#CefBrowser_N.cpp-1393 https://bitbucket.org/chromiumembedded/java-cef/src/304f3e3de03fb3aab5e8212c0f9c699503a55cb4/native/jni_util.cpp?at=master#jni_util.cpp-126

https://stackoverflow.com/questions/32205446/getting-true-utf-8-characters-in-java-jni/32215302

Hinaser commented 3 years ago

I've just submit a fixed version to JetBrains. Once they approve it, you can update the plugin. Thank you for reporting issue!

Hinaser commented 3 years ago

https://plugins.jetbrains.com/plugin/14683-gfma v0.0.4 is now available! Closing.