HinodeXRT / xrtpy

https://xrtpy.readthedocs.io
BSD 2-Clause "Simplified" License
12 stars 8 forks source link

Feature request: user-provided spectra in temperature response functions #51

Open kreevescfa opened 2 years ago

kreevescfa commented 2 years ago

Right now temperature response functions read spectra out of a gene file. We would like to expand the functionality so that a user can optionally supply their own spectra.

wtbarnes commented 2 years ago

Very similar thread on the aiapy repo: https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/issues/23#note_296346341. I had scoped out a similar though slightly more abstract plan to have an EmissionModel object, composed of some number of ions and perhaps transitions per ion, that the user could construct and then pass in to some temperature response function. This would allow you to build up the inputs to your temperature response model in a very natural way. The missing piece in that effort was how to generate that spectra (or list of emissivities).

kreevescfa commented 2 years ago

Is ChiantiPy not sufficient for that?

Anyway, my thought for this feature was to allow the user to input the spectra in some predetermined format, but the onus of actually generating the spectra would be on the user.

Kathy

On Jun 28, 2022, at 2:29 PM, Will Barnes @.***> wrote:

Very similar thread on the aiapy repo: https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/issues/23#note_296346341. I had scoped out a similar though slightly more abstract plan to have an EmissionModel object, composed of some number of ions and perhaps transitions per ion, that the user could construct and then pass in to some temperature response function. This would allow you to build up the inputs to your temperature response model in a very natural way. The missing piece in that effort was how to generate that spectra (or list of emissivities).

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

wtbarnes commented 2 years ago

I believe chiantipy could definitely do that. I was thinking in the same vein. The EmissionModel could just be general interface for specifying the spectrum, regardless of how that spectrum was generated.