Reworks: Dorfromantik + ISLANDERS + PAC-MAN CE-DX + Luck be a Landlord

HintMachine / hintMachine

HintMachine is a program giving hints for your Archipelago games.

MIT License

9 stars 11 forks source link

Reworks: Dorfromantik + ISLANDERS + PAC-MAN CE-DX + Luck be a Landlord #25

Closed nbrochu closed 8 months ago

nbrochu commented 8 months ago

In this PR

Dorfromantik

Now looking at different structs (RewardSystemData) that have the state of the last 2 moves instead
Found solid pointers to those new structs (extensively tested). Documented some backups just in case
Added new quests for Quests Fulfilled + Perfect Tile Placements
Now handling process being killed correctly

ISLANDERS

Now looking at LocalGameManager struct instead
Found solid pointer to that new struct (extensively tested)
Added new quests for Booster Packs Earned + Islands Visited
Now handling process being killed correctly

PAC-MAN Championship Edition DX+

Minor: Rename Cumulative Score to Score for consistency across implementations

Dinopony commented 8 months ago

I was only able to test Dorfromantik since it's the only game I own, and sadly it doesn't work. To be more precise:

it connects without problem and doesn't automatically disconnect (compared to before this PR when it disconnected instantly after connecting)
quests don't make any progress

I can help troubleshoot if you send me CheatEngine scan tables or stuff like that to see which pointer path would work on my end

nbrochu commented 8 months ago

Hmm, that's really weird. Starting to wonder if we even have the same executable. Can you hash yours just to make sure?

SHA256: 4c7312a39fa8401af0d51d210931dae8c8d85bbfe8e1c7f22e8a553e6d00b0ee

Dinopony commented 8 months ago

I've got 4C7312A39FA8401AF0D51D210931DAE8C8D85BBFE8E1C7F22E8A553E6D00B0EE, which looks the same.

nbrochu commented 8 months ago

OK I'm going to assemble a table and send it your way

nbrochu commented 8 months ago

I also have a commented out alternate set of pointers to try in the code in the meantime

Dinopony commented 8 months ago

I also have a commented out alternate set of pointers to try in the code in the meantime

Which ones should I use, the ones marked "Backup pointer" such as there : https://github.com/SerpentAI/hintMachine/blob/544ca1f088db1e00537f9dc5946bf1f0f709341c/HintMachine/Games/DorfromantikConnector.cs#L71

nbrochu commented 8 months ago

This should be it. I DMed you a CT table with a bunch of pointer candidates for Dorfromantik just in case.

Dinopony commented 8 months ago

Still doesn't work for me, I DM'ed you the filtered table with invalid pointers (on my system at least) removed

nbrochu commented 8 months ago

We figured out it didn't work because I forced pushed and the already checked out branch wouldn't update for Dinopony (of course). I will be clearer going forward when I force push post-rebase.