HintMachine / hintMachine

HintMachine is a program giving hints for your Archipelago games.
MIT License
9 stars 11 forks source link

Super Mario Bros. 2 and HintQuestSingle #87

Closed RadzPrower closed 7 months ago

RadzPrower commented 8 months ago

Included in this pull request is the implementation of Super Mario Bros. 2 for the NES.

It includes the following repeatable quests:

It also includes the following four quests of the new Single type:

These missions utilize the new class and once the goal has been reached, the bar will change to say Completed and progress with no longer be tracked. The class is a child of HintQuestCounter and overrides the CheckAndComitCompletion, InitComponents, and UpdateComponents methods as well as replicate some of the variables from the parent class. If there is a way to implement this without the need of these variable assignments or the InitComponents method which was copied directly from the parent, I will be happy to remove them as I don't like the idea of duplicating code, but the variables were needed as part of the UpdateComponents override.

RadzPrower commented 8 months ago

I have commented out portions of HintQuestSingle that are no longer compatible with the parent class. This retains the functionality of the single clear quest, but does not change the way the quest bar is displayed at this time.

I will need to research the new method before I consider making those types of changes again.