Hintful / aram.tools

A full-stack web application that analyzes and visualizes users' performance for a popular online game, League of Legends.
https://aram.tools
2 stars 0 forks source link

Need to be able to show actual Summoner Name for Challenges leaderboard #32

Closed Hintful closed 1 year ago

Hintful commented 1 year ago

Motivation

We currently have a working Challenges leaderboard (#30) - but the Riot API for fetching this leaderboard returns entries with PUUID instead of actual summoner name.

My initial approach was creating an API endpoint on our end for fetching summoner info with PUUID and then hitting that API from front-end to fetch individual entries' summoner name, but this seems very unreliable and hacky.

Ideal solution seems to be the following:

Acceptance Criteria

Hintful commented 1 year ago

The issue has been resolved with PR #37.

Currently, the summoner info fetch via PUUID is done on the front-end side. In the future, we might explore the option of doing this in the back-end to see if it improves loading performance. Resolving for now.