search

Hintful / aram.tools

A full-stack web application that analyzes and visualizes users' performance for a popular online game, League of Legends.
https://aram.tools
2 stars 0 forks source link

Use response from Riot API to show actual summoner name for ProfileHeader #45

Closed Hintful closed 1 year ago

Hintful commented 1 year ago

Motivation

Currently for the <ProfileHeader/>, we keep the exact value that the user typed in.

For example, even if a player's actual summoner name is Unknown Summoner 1, if we search for unknownsummoner1, even though it will fetch correct player data from Riot API, the ProfileHeader will continue to say unknownsummoner1. We want to change this so that actual summoner name is shown in the ProfileHeader.

Acceptance Criteria

Hintful commented 1 year ago

The issue has been resolved with PR #47. Resolving.