search

HipByte / Flow

Cross-platform libraries for RubyMotion
BSD 2-Clause "Simplified" License
141 stars 29 forks source link

Fix bug in measuring size of nil label #34

Closed andrewhavens closed 7 years ago

andrewhavens commented 8 years ago

This PR fixes #31 by returning a size of zero when the label title is nil.

jjaffeux commented 8 years ago

@andrewhavens shouldn't we check for empty too ?

andrewhavens commented 7 years ago

@jjaffeux I have rebased this branch, added a check for empty, and added a unit test. Please review and merge or let me know what needs to change.

jjaffeux commented 7 years ago

@andrewhavens sorry, I'm stepping down from RM, and using it less and less, don’t want to be involved in it anymore.

andrewhavens commented 7 years ago

@lrz Who can we ask to merge pull requests? There are several open here and in https://github.com/HipByte/motion-game/pulls. I don't have access to merge but would be happy to if you want to grant me access.

lrz commented 7 years ago

I’m sorry I thought you had access already… I added you as a collaborator, hopefully you will have the proper permissions now. Let me know if it doesn’t work!

On 05 Nov 2016, at 1:15 AM, Andrew Havens notifications@github.com wrote:

@lrz https://github.com/lrz Who can we ask to merge pull requests? There are several open here and in https://github.com/HipByte/motion-game/pulls https://github.com/HipByte/motion-game/pulls. I don't have access to merge but would be happy to if you want to grant me access.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/HipByte/Flow/pull/34#issuecomment-258576967, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAiN6wQoWs3zuQOJLUS3tWDFs5DbMdJks5q68qGgaJpZM4JUzpX.