search

Hipo / university-domains-list-api

The API server for the University Domains
MIT License
175 stars 44 forks source link

API Doesn't Update when JSON is Updated #7

Closed dl-eric closed 5 years ago

dl-eric commented 5 years ago

Currently, the server only loads the data once in its lifetime. This means that the server needs to be restarted in order to refresh its college list.

I'm adding this issue to begin discussion to mitigate this. I am unsure if maintainers would want to manually restart the server every time the list is updated, so I'm proposing that we create an endpoint that would force a refresh. To prevent malicious spamming of the endpoint, we can enforce that the server at most refreshes the data once every 24 hours.

yigitguler commented 5 years ago

This is a good idea. PR will be appreciated :)

dl-eric commented 5 years ago

Now that this has been merged, is it possible to update the public API?

yigitguler commented 5 years ago

Done!

yigitguler commented 5 years ago

Thank you.

dl-eric commented 5 years ago

Huge thanks!