search

HippieStationArchive / HippieStation13-1

https://github.com/HippieStation/HippieStation13
https://github.com/HippieStation/HippieStation13
GNU Affero General Public License v3.0
28 stars 92 forks source link

Chems can be heated past 1000K #2971

Open ArcLumin opened 8 years ago

ArcLumin commented 8 years ago

Chems can be heated past 1000K using a lighter or similar heating implement.

Delimusca commented 8 years ago

glass.dm#L131 there's the heating code. checked the lighter, still had the proper heat value. what container did you heat? might be a missing check.

ArcLumin commented 8 years ago

A beaker

ArcLumin commented 8 years ago

Zippo Lighters have a heat value of 1500, which might explain part of it

KayeArray commented 8 years ago

This is intended.

I think, otherwise there wouldn't be a limit.

Delimusca commented 8 years ago

ah right, the weird extra zero on the ishot values, think that was for atmos or something. easy enough to solve, just need to check for heat being > (ROOMTEMP + (heat / 10))

the chem heating system needs a redo anyway, i didn't put much work into it and it's got copypasta everywhere; probably could be moved up to /obj even.

ArcLumin commented 8 years ago

Considering there's a limit on chem heaters at 1000K, and it's considered in commenting as the "Max Value", I think it's an oversight, at least.