Closed ghost closed 7 years ago
ghost
commented
7 years ago Note that I haven't actually tried to figure out what's making ninja such a pain in the ass whenever more than one are spawned. Right now I'm just cleaning everything up.
Oh, yeah. Also need an In Progress tag.
ghost
commented
7 years ago Well, people want to code new shit for it, so it has to be fixed. It may not even be the suit. I feel like it's either the way ninjas are selected, or some of the code the older coders wrote about in the readme that they were trying to phase out.
Either way, I'm running a fine toothed comb through everything, I'll get it eventually. One of the steps in this process will be re-evaluating all of the ninja's abilities as well as the suit, and gradually re-writing it from the ground up.
Right now my priority is to get this relocated and compressed code working on at least the same level as the old code.
KayeArray
commented
7 years ago I wish you the best of luck in this horrid endeavor
ghost
commented
7 years ago Code is functional as of now, and can even be merged if someone chooses to do so. I haven't actually gotten around to seeing if merging all this shit fixed the runtimes or not, but I can guarantee that the code runs either the same as it did before or better.
If the code gets merged as a bugfix or whatever, then I'll open a new PR with the actual overhauls. Otherwise I'll just keep working on it with this PR.
TheOneAndOnlyCreeperJoe
commented
7 years ago Go looking for runtimes by having multiple space ninjas do various things at the same time.
The biggest runtime issues are when there's multiple.
ghost
commented
7 years ago That's the plan. I'll hunt for a gerbil later on today, but the code is stable so far with one ninja.
ghost
commented
7 years ago It looks like either the merging or the move fixed the runtimes. Had four ninjas spawned in at once with no runtimes. Only bug we ran into was that one of the ninjas' abilities wasn't working right, but the issue resolved itself once he re-initialized his suit and it never happened again.
As far as I'm aware, everything is fixed and ready for merging. Even if it wasn't 100% fixed, it's still an improvement over the old code.
ghost
commented
7 years ago 
Work in progress. Moving everything to events, compressing as much as possible, removing uneccessary junk, then fixing any remaining bugs. If the event is still a problem after this, at least it's a nicer looking problem. Putting this up now because the previous coders who worked on this went out of their fucking way to make this as much of a pain in the ass as possible, and I'll be needing a combination of tips and moral support.