HippieStationArchive / HippieStation13-1

https://github.com/HippieStation/HippieStation13
https://github.com/HippieStation/HippieStation13
GNU Affero General Public License v3.0
28 stars 92 forks source link

the saxophone does the thing sound effects do of changing pitch despite playing music #3398

Closed cacogen closed 7 years ago

cacogen commented 7 years ago

if you haven't noticed, sound effects pick a random pitch when they play so that when the same sound effect repeats each one sounds unique

but this extends to the saxophone which plays saxophone clips from pop songs and this results in the songs played being randomly sped up or slowed down

would be better if by default they played at regular speed and there was an option to play them back at a different tempo if you wanted

ArcLumin commented 7 years ago

This is fine, it's a feature

cacogen commented 7 years ago

is it a feature? i think it's an unintended side effect of the way the playsound() proc works

i can understand if you don't think it's worth doing anything about, but at least say that

edit: actually i think it's just from copy and pasting the playsound proc (most of the time it's used with the volume at 50 and pitch varying on), you'd just have to set the vary value to 0 here as per the proc definition

ArcLumin commented 7 years ago

I dunno if it's a feature or not, but it certainly makes stuff more fun, as it's not the same sound effect every time, it feels less spammy.

cacogen commented 7 years ago

i don't care enough