search

Hipposgrumm / armor-trims

2 stars 1 forks source link

All upgrade recipes work independently of the upgrade templates. #23

Closed QwertRvg closed 1 year ago

QwertRvg commented 1 year ago

2023-07-03_17 51 47 Additional Additions allows creating Gilded Netherite using a Golden Ring.

2023-07-03_17 51 53 But for some reason with the Armor Trims mod, it is both possible to upgrade with and without the Netherite Upgrade. Creating the Gilded Netherite set is not upgrading to Netherite, so it shouldn't work with the Netherite Upgrade item. It should only work without it

Hipposgrumm commented 1 year ago

So netherite upgrading is just weird then I guess. Now that I can confirm this I can investigate it further.

QwertRvg commented 1 year ago

Did you close this because you fixed or because you deemed it unnecessary to do so? I just updated the mod and tried again, the issue still persists. When using the 'Netherite Upgrade', the new slot should only accept Netherite Ingots. Unlike with the other Smithing Templates, the Upgrade doesn't allow customization anyway, so other items don't need to go into the slot ever. image_2023-08-09_201156258

Hipposgrumm commented 1 year ago

I guess this ties into #29. Now I know that I probably need to invert a boolean value now.

Hipposgrumm commented 1 year ago

Also, you can add custom upgrade templates using the mod’s built-in API (assuming it works).

Hipposgrumm commented 1 year ago

So apparently it’s not as simple as flipping a value. I’ll probably need to rewrite the whole upgrading system.

QwertRvg commented 1 year ago

Thank you so much! The issue was fixed with the latsest update