Hipposgrumm / armor-trims

2 stars 1 forks source link

Server seems to ignore config to make items Untrimmable #26

Closed TorchTheDragon closed 1 year ago

TorchTheDragon commented 1 year ago

Exactly as the title states. here is an image of an item still having the Armor Trim tab and still allowing me trim it, even though I have disabled the item in the configs.

imageimage

Also, just found out that even though I have the "Don't consume Trim" option enabled, it still did.

I have also attached the config file to show that it is in there. The specific item used in the image is "weavers_cosmetics:gilded_knights_armour_helmet". Also, I just converted the .toml to a .txt cuz GitHub don't like it armor_trims.toml.txt

TorchTheDragon commented 1 year ago

Admittedly, it could be other mods in the pack, though idk what would prevent the reading of a config.

TorchTheDragon commented 1 year ago

Using Create, it also shows that the field is empty for Untrimmable Items, yet in the server file manager, it isn't. It is a very long list.

Create Config Editor: image

Server File Manager: image image

Hipposgrumm commented 1 year ago

Modpack Maketh Mode doesn’t exactly work and I am aware of this.

TorchTheDragon commented 1 year ago

One thing that could be noted is it does work fine when in singleplayer

Hipposgrumm commented 1 year ago

Do you have it set in the server’s config?

TorchTheDragon commented 1 year ago

Using Create, it also shows that the field is empty for Untrimmable Items, yet in the server file manager, it isn't. It is a very long list.

Create Config Editor: image

Server File Manager: image image

That's what this was showing, one was me in world (using creates config editor) and the other is the direct server file

Also, the text file in the initial comment is the same file from the server, just renamed to a txt file so I could send through GitHub

TorchTheDragon commented 1 year ago

Also, those armors in that list are just straight up incompatible, hence why I put the list there on the server. If ya want, I can go on a grind and try to find as many as possible so there is a list available. Two mods I know that are fully incompatible are Immersive Armors and Weavers Cosmetics.

Can I also make a suggestion for when you get this working to make a wildcard tag thing, so like if you want to remove all armor from a mod you could just do "modname:" with the being the wildcard

Hipposgrumm commented 1 year ago

You don’t need to go on a giant goose chase. I’ll probably add a feature where custom models will refuse to be trimmed based on what the client says if it’s a custom model.

Hipposgrumm commented 1 year ago

I figured out why this doesn't work. Apparently I forgot to assign everything to everything.

PINPAL commented 1 year ago

Is this fixed? Also encountering the same issue and was hoping I could prevent Create's backtank/diving gear from being trimmed as it causes you to be wearing a giant purple box. image

My config:

# Disable trimming for any items that don't work when trimmed.
"Untrimmable Items" = [
    "create:netherite_backtank",
    "create:copper_backtank",
    "create:netherite_diving_boots",
    "create:netherite_diving_helmet",
    "create:copper_diving_boots",
    "create:copper_diving_helmet",
    "ironjetpacks:jetpack",
    "railways:white_conductor_cap",
    "railways:orange_conductor_cap",
    "railways:magenta_conductor_cap",
    "railways:light_blue_conductor_cap",
    "railways:yellow_conductor_cap",
    "railways:lime_conductor_cap",
    "railways:pink_conductor_cap",
    "railways:gray_conductor_cap",
    "railways:light_gray_conductor_cap",
    "railways:cyan_conductor_cap",
    "railways:purple_conductor_cap",
    "railways:blue_conductor_cap",
    "railways:brown_conductor_cap",
    "railways:green_conductor_cap",
    "railways:red_conductor_cap",
    "railways:black_conductor_cap",
    "minecraft:shulker_shell",
]