search

HipsterBrown / xs-dev

The quickest way for getting started with JS on devices
https://xs-dev.js.org
MIT License
37 stars 13 forks source link

feat(setup): use versioned release artifacts in Windows "xs-dev setup" #136

Closed andycarle closed 1 year ago

andycarle commented 1 year ago

This update to xs-dev setup for Windows mirrors the macOS setup process by:

  1. Performing a shallow clone of the Moddable SDK repo
  2. Using the versioned release of the Moddable SDK tools rather than building from source

Like on macOS, this approach uses the versioned release tools as both the "release" and "debug" binaries in build/bin/win/release and build/bin/win/debug, respectively.

When I get a chance, I'll make a new version of #91 built on this change. But no reason to wait on that to get this smaller change in, imho.

phoddie commented 1 year ago

Like on macOS, this approach uses the versioned release tools as both the "release" and "debug" binaries in build/bin/win/release and build/bin/win/debug, respectively.

FWIW – in theory it should no longer be necessary to have the debug binaries. There were some unintentional dependencies on the debug binaries but those have been cleaned up.