HipsterBrown / xs-dev

The quickest way for getting started with JS on devices
https://xs-dev.js.org
MIT License
41 stars 13 forks source link

^C doesn't stop build #29

Closed phoddie closed 2 years ago

phoddie commented 2 years ago

On macOS, start a build with

> xs-dev run --example piu/balls

Press Control C. The terminal prompt appears, as expected, but the build continues in the background, eventually launching xsbug and the simulator.

phoddie commented 2 years ago

^C now works! Thank you!

It looks like all the build output is being suppressed now?

$ xs-dev run --example helloworld --device esp8266
⠸ Building and running project /Users/hoddie/.local/share/moddable/examples/helloworld on esp

The build is kind of noisy, but some progress is helpful too. I'm not sure what the right balance is there, but something to consider.

HipsterBrown commented 2 years ago

Yea I removed the build output for now because the process would still output a little bit after the CTRL-C signal.

It might be helpful to create a --debug or --verbosity option for folks that want to see it.

phoddie commented 2 years ago

Makes sense.

FWIW – a behavior I've seen to output a single line that replaces itself. Parts of the ESP-IDF build for ESP32 do this. I like it because it shows the activity without generating a huge amount of output in the terminal.