search

HiranChaudhuri / OoliteStarter

This repository has moved. You can find it now at https://github.com/OoliteProject/OoliteStarter
https://github.com/OoliteProject/OoliteStarter
GNU General Public License v3.0
16 stars 0 forks source link

Should run-linux.sh use "java" instead of "javaw"? #10

Closed rogerm4242 closed 10 months ago

rogerm4242 commented 10 months ago

Describe the bug Should run-linux.sh use "java" instead of "javaw"? To the best of my knowledge this link shows why it would be better to use "java": https://stackoverflow.com/questions/14331406/why-javaw-is-not-found-on-my-java-installation-on-ubuntu

To Reproduce Steps to reproduce the behavior:

  1. From a terminal prompt in the OoliteStarter folder, execute run.sh or run-linux.sh
  2. Error: "javaw: command not found"

Expected behavior OoliteStarter should open

Environment (please complete the following information):

HiranChaudhuri commented 10 months ago

Your change looks good and it is merged. Thank you for pointing it out. Is the intended behaviour now reproducible?

rogerm4242 commented 10 months ago

I am afraid I do not have a java development environment set up to build/compile the project to fully test this.

I simply edited the shell script with a text editor on my 2 linux boxes. Changing "javaw" to "java" made everything work on both systems for me. I would consider this issue solved.

BTW, Thanks for your work on this project. I am a new player enjoying Oolite!

HiranChaudhuri commented 10 months ago

There is no need to setup a dev environment. I 4-eyed your change and found it good. Since I merged the new version got built automatically. So you might want to download OoliteStarter 0.1.19 just to verify your change still looks as intended. If it does we can close the issue.

Happy to hear you are having fun!

rogerm4242 commented 10 months ago

OK, thank for pointing that out.

I downloaded OoliteStarter-0.1.19-generic.tar.gz and extracted it on my Ubuntu 22.04 system and the included run.sh launched correctly for me.

HiranChaudhuri commented 10 months ago

Thank you for that confirmation. I will close the issue then. :-)