Cancel doesnt work on "waiting for process to complete"

HiranChaudhuri / OoliteStarter

This repository has moved. You can find it now at https://github.com/OoliteProject/OoliteStarter

https://github.com/OoliteProject/OoliteStarter

GNU General Public License v3.0

16 stars 0 forks source link

Cancel doesnt work on "waiting for process to complete" #14

Closed ihaveamo closed 2 months ago

ihaveamo commented 8 months ago

Describe the bug Cancel doesnt work on "waiting for process to complete"

To Reproduce

Kill oolite.exe
attempt to cancel

HiranChaudhuri commented 8 months ago

At least on my Linux setup using xkill on Oolite restores OoliteStarter as intended. Could you provide a logfile and maybe the list of running processes?

HiranChaudhuri commented 8 months ago

Admittedly there is something strange on "waiting for process to complete". It can show up in a situation where Oolite is not running at all. To reproduce:

Run OoliteStarter
Start/resume a game -> this brings up Oolite
either exit Oolite, or kill it, or bring up OoliteStarter and kill via the Cancel button
switch to the Expansions tab
install or uninstall some expansion
when MrGimlet should show up, the WaitPanel shows up and cannot be removed

This has worked on the currently latest v0.1.21-elul.8

HiranChaudhuri commented 2 months ago

I checked commit https://github.com/HiranChaudhuri/OoliteStarter/commit/da8130c24ab068382792009013daee657702090e to fix both the OP's situation (a killed Oolite is detected correctly - no need to press cancel) and the situation I described.

Please check if the new release https://github.com/HiranChaudhuri/OoliteStarter/releases/tag/v0.1.29-flavescent.5 also works for you.

HiranChaudhuri commented 2 months ago

OP's issue cannot be reproduced. Intermediate issue is fixed.