search

HiranChaudhuri / OoliteStarter

This repository has moved. You can find it now at https://github.com/OoliteProject/OoliteStarter
https://github.com/OoliteProject/OoliteStarter
GNU General Public License v3.0
16 stars 0 forks source link

Bad ManagedAddOns folder name #16

Closed yomli closed 5 months ago

yomli commented 5 months ago

Describe the bug

When created by OoliteStarter (as in: not by Oolite itself), the ManagedAddOns folder is spelled ManagedAddons on Windows.

To Reproduce

Steps to reproduce the behavior:

  1. Install OoliteStarter on Windows
  2. Install Oolite on Windows
  3. DO NOT start Oolite, instead start OoliteStarter
  4. Follow the instructions provided by OoliteStarter to add a version of Oolite
  5. Save this version
  6. Check the name of the ManagedAddOns folder either in OoliteStarter, in the .oolite-starter.conf file, or at GNUstep/Library/ApplicationSupport/Oolite/ManagedAddons

Expected behavior

Should create a ManagedAddOns folder.

Environment (please complete the following information):

I stumble upon this while making a new install of Oolite on Windows, using OoliteStarter before launching Oolite for the first time. In that case, since the ManagedAddOns folder doesn't exist, OoliteStarter creates it under GNUstep/Library/ApplicationSupport/Oolite/ManagedAddons: https://github.com/HiranChaudhuri/OoliteStarter/blob/bde5384b9bc304c1d296d75588a4081dbc32e432/src/main/java/oolite/starter/Oolite.java#L2165

If you don't see the issue, look closer: the "o" must be uppercase. Why on Earth would we care since Windows isn't case sensitive? Because the Telescope OXP uses a Python script (or the exe conversion of said Python script) which is case sensitive, failling to find the required ManagedAddOns folder.