HiranChaudhuri / OoliteStarter

This repository has moved. You can find it now at https://github.com/OoliteProject/OoliteStarter
https://github.com/OoliteProject/OoliteStarter
GNU General Public License v3.0
16 stars 0 forks source link

Windows exe doesn't launch the MSI installer since 0.1.27-fantail.2 #20

Closed yomli closed 5 months ago

yomli commented 5 months ago

Describe the bug Windows executable available in the releases doesn't launch the integrated MSI installer. When normally executed, the exe installer launch a msiexec.exe process which takes care of everything. Since 0.1.27-fantail.2, the msiexec.exe is indeed launched, but does nothing, so the main process just hangs without any notice nor window. It appears as a closed app, but it can be seen in the Task Manager just waiting for msiexec.exe.

To Reproduce Steps to reproduce the behavior:

  1. Download any release from fantail.2 onward.
  2. Double-click the exe. A window appears then immediately disappears (that is the expected behaviour with the previous releases).
  3. No new window appears, the whole process seems to have shut down.
  4. Open the Task Manager and see the OoliteStarter-0.1.27-fantail.4-Windows.exe process just waiting for one or two msiexec.exe to finish.

Expected behavior MSI installer should launch like it did in previous releases.

Environment (please complete the following information):

Additional context Ok, I will close this bug as soon as it is posted, since I found why it occurs. I didn't understand why the OoliteStarter installer on my fork worked but not the one here, since the two came from the same build process on GitHub.

The trick is: I don't know why, but my fork is labeled 0.1.0. I had to extract your release and launch the main.msi file using this command to get the log: msiexec /i "installer.msi" /l*v "log.log" The issue occurs because all of the fantail and obviously the final 0.1.27 have the same product version:

MSI (c) (D4:F4) [17:36:10:220]: Windows Installer reconfigured the product. Product Name: OoliteStarter. Product Version: 0.1.27.0. Product Language: 1033. Manufacturer: Unknown. Reconfiguration success or error status: 1638.

Therefore, the MSI installer fails to install the new versions on the basis that the 0.1.27.0 version is already installed. A poor OS indeed… The workaround for the user is just to uninstall the previous version before installing a new "patch" of the same version. I submit this bug report in order to help any user facing the same "bug".