search

HirbodBehnam / Shadowsocks-Cloak-Installer

A one-key script to setup Cloak plugin with Shadowsocks on your server
GNU General Public License v3.0
420 stars 88 forks source link

Fix aes-gcm related configuration options #37

Closed cbeuw closed 3 years ago

cbeuw commented 3 years ago

First of all I just want to say thank you very much for making and continuously maintaining this script, which enabled many less tech-savvy people to circumvent internet censorship.

This PR fixes some issues introduced in https://github.com/HirbodBehnam/Shadowsocks-Cloak-Installer/commit/999f320e9992fd96278bd5c67f511898b8616443. The main thing is that Cloak's naming of AES-GCM ciphers have the key size in the middle (like aes-128-gcm), rather than at the end. The numbering in cipher selection has a duplicate "3", this is fixed as well

HirbodBehnam commented 3 years ago

Well I'm so sorry for being this much dumb for not double checking the documentation and not testing my own code and pushing directly to master :| And we should actually thank you for creating cloak for people to circumvent internet censorship :)

cbeuw commented 3 years ago

No worries! I just happened to come across it and spotted the issue. I don't think any end user was affected