Hirenachhaada / Mern-Chat-Application

1 stars 11 forks source link

Change Password #16

Closed Hirenachhaada closed 8 months ago

Hirenachhaada commented 9 months ago

The user should be able to change his password. It should first ask for it's old password. After checking the old password change to password to new password.

NandishM0618 commented 9 months ago

@Hirenachhaada please assign this issue to me I would like to work on it.

Hirenachhaada commented 9 months ago

done

Hirenachhaada commented 9 months ago

you can start working on it. Read the readme file for starting the project in your system.

NandishM0618 commented 9 months ago

issue18 issue19 issue20 I have implemented change password. if you need changes in design please update me. can I make pull request if wanted?

Hirenachhaada commented 9 months ago

Nice. Also, add a confirm new password input box. And then you can create a pull request. Nice work.

NandishM0618 commented 9 months ago

Okay

NandishM0618 commented 9 months ago

issue21 if confirm password does not match it will show error like this. I have created a pull request please review it #19 if any changes please update me.

Hirenachhaada commented 9 months ago

ok nicely done. But there is a big mistake. It should not be in the profile section. When you click on someone else profile pic/ view profile button, it will allow you to change other's password also, which is not possible. So just Create a new option in the dropdown for change password. Also add option to show and hide password.

NandishM0618 commented 9 months ago

Okay

NandishM0618 commented 9 months ago

issue22 issue23 I have made changes please review it #19 if any changes required please update me. If you like it please merge it and update points.