Hirenachhaada / Mern-Chat-Application

1 stars 11 forks source link

Fix the size of message container of different attachments #4

Closed Hirenachhaada closed 8 months ago

Hirenachhaada commented 9 months ago

For different attachments the size of message container should dynamically change. you can see the bug in the attached image the extra space after the main image is of no use. image

Similarly fix it for all the types of attachments

Surajit0573 commented 9 months ago

I can fix this issue, please assign me !!!

Hirenachhaada commented 9 months ago

First work on this issue. Then you can move to next issue

Albert-2 commented 8 months ago

hey @Hirenachhaada can you please assign me the issue as I am quite good at responsive designs and frontend THANK YOU FOR CONSIDERING...... :)

Hirenachhaada commented 8 months ago

Ok start working on it

Albert-2 commented 8 months ago

ok..... 👍

Albert-2 commented 8 months ago

hey @Hirenachhaada i've made a PR please review it If anything wrong or not as expected then please let me know Thank You....

Hirenachhaada commented 8 months ago

ok nice your feature is working for different images but not for all type of attachments like video or audio and many more. Try to fix it image image

Albert-2 commented 8 months ago

hey @Hirenachhaada done what you asked Still missed something then please do let me know...... ✌️

Hirenachhaada commented 8 months ago

Have you fixed it for all types of attachments?

Hirenachhaada commented 8 months ago

Just share a screenshot

Albert-2 commented 8 months ago

image

here ....

Hirenachhaada commented 8 months ago

Ok nice, i am busy at some work. Will review and merge your code at night. By the way nice work 😀😀

Hirenachhaada commented 8 months ago

And one more thing , have you used any split function or any thing like that, because when i was trying to run it in my local environment, i was getting error related to it. Please check once

Albert-2 commented 8 months ago

i also suffered from that "split function not applicable to undefined" problem but i fixed it and on my side its working like a charm

image

image

Albert-2 commented 8 months ago

https://github.com/Hirenachhaada/Mern-Chat-Application/pull/29

check this branch its completely working as expected