search

Hirlam / obsmon

Tool for observation monitoring in the Harmonie-Arome NWP system
https://hirlam.github.io/obsmon/
MIT License
3 stars 8 forks source link

Fixed map plot areas in 3.11.0 #6

Closed ewhelan closed 3 years ago

ewhelan commented 3 years ago

Hi Paulo,

I hope you are still supporting 3.11.0!

In 3.3.2 I fixed map plot area with the following in src/plots/plots_maps.R with the following:

#EOIN x1 <- min(plotData$longitude)-2 #EOIN x2 <- max(plotData$longitude)+2 #EOIN y1 <- min(plotData$latitude)-2 #EOIN y2 <- max(plotData$latitude)+2 x1 <- -35 x2 <- 5 y1 <- 45 y2 <- 65 This doesn't seem to work in 3.11.0. Do you have any insight?

paulovcmedeiros commented 3 years ago

Hi Eoin,

I'm not really supporting v3.11.0... I changed quite a lot of stuff related to the used R-packages. My guess is that something changed in the plotting libraries (maybe ggplot2 or plotly), but this is just a guess.

My advice would be for you to upgrade and try your fix in the new version.

I'm gonna close this since this is not really an issue (your fix is quite specific to the area you want to cover, and one can always pan, zoom in and out of the maps to select a different area).

ewhelan commented 3 years ago

Thanks Paulo.

Hacked the plotly geo specification to sort this.

Will brave v4.X soon!

Eoin