search

HiroIshida / detic_ros

ROS wrapper for pretrained Detic instance segmentation and detection (and some utils to work with point cloud)
MIT License
28 stars 14 forks source link

refactor: wrapper should not have internal state #37

Closed HiroIshida closed 1 year ago

HiroIshida commented 1 year ago

I think DetecWrapper should be just a function, and should not have any internal state. Based on this concept, the source code is refactored.

@Affonso-Gui

Affonso-Gui commented 1 year ago

Cool! Having a separate class for the results makes it much cleaner. Thanks for taking the time to fix this!

HiroIshida commented 1 year ago

@Affonso-Gui Thanks for you review I reflect your review in https://github.com/HiroIshida/detic_ros/commit/e3596bd88c02f9f99f4dac2688741b6d886e2b57