Add arg to change target_frame_id in sample_detection.launch

HiroIshida / detic_ros

ROS wrapper for pretrained Detic instance segmentation and detection (and some utils to work with point cloud)

MIT License

28 stars 14 forks source link

Add arg to change target_frame_id in sample_detection.launch #41

Closed tkmtnt7000 closed 1 year ago

tkmtnt7000 commented 1 year ago

This PR enables us to change target_frame_id param that is used in ClusterPointIndicesDecomposer.

target_frame_id is different among robots (eg. base_footprint in PR2 vs base_link in Fetch)

HiroIshida commented 1 year ago

Thanks! I didn't check it yet, but probably, the reason why Peripheral test failed is the default ubuntu version is github action is 22.04. (On the other hand, docker image is build upon ubuntu 20.04, thus the rostest in that passed, I guess.

tkmtnt7000 commented 1 year ago

Thank you for merging. I will also confirm peripheral test and will debug it when I have time.

HiroIshida commented 1 year ago

No worries, The failure is fixed in https://github.com/HiroIshida/detic_ros/pull/42 before merging this PR