HiroIshida / yamaopt

robotic optimal sensor placement
MIT License
0 stars 1 forks source link

Add constraints: movable polygon #29

Closed 708yamaguchi closed 2 years ago

708yamaguchi commented 2 years ago

I add

I do not have confidence in how to add base constraints... Could you give me any advice? @HiroIshida https://github.com/HiroIshida/yamaopt/commit/0c36760ebe40e05fbe9126388741b5aef7f18c2f#diff-170e94d0e06d6b25b36d255e6b99d511f3e5dcd0efbc8a7e34bb5b1d8c267f2eR136-R146

example.py no limit base limit
single_no_limit single_base_limit
example_multi.py no limit base limit
multi_no_limit multi_base_limit
HiroIshida commented 2 years ago

@708yamaguchi Nice new feature! Could you add a test for jacobian computation of base_constraint_from_polygon in https://github.com/HiroIshida/yamaopt/blob/be79084eb5db9e66d88485305b9cc31e36bd906f/tests/test_solver.py#L45 like the test for configuration constraint in https://github.com/HiroIshida/yamaopt/blob/be79084eb5db9e66d88485305b9cc31e36bd906f/tests/test_solver.py#L63 ?

708yamaguchi commented 2 years ago

ok!

I will do tomorrow!

708yamaguchi commented 2 years ago

Thank you for your review!

I add test in 0058d32 (#29)