search

HiromuHota / pentaho-kettle

webSpoon is a web-based graphical designer for Pentaho Data Integration with the same look & feel as Spoon
https://hub.docker.com/r/hiromuhota/webspoon/
Apache License 2.0
502 stars 192 forks source link

Canvas - Properties Dialog overlaps with Data Plugin additions to it. #122

Open usbrandon opened 6 years ago

usbrandon commented 6 years ago

Expected Behavior

I expected to see a clean properties dialog box where the pentaho-pdi-dataset plugin's entries are listed with the normal properties.

Actual Behavior

I see both the original dialog and the pentaho-pdi-dataset-plugin dialog transposed on top of each other. Screenshots and error messages are helpful. Overlap Problem

Steps to Reproduce the Problem

  1. http://sandbox.kettle.be:8080/spoon/spoon
  2. Right click on the canvas

Client

HiromuHota commented 6 years ago

I was able to reproduce this issue. Thank you for reporting. I also confirmed that this does not happen on Spoon.

HiromuHota commented 6 years ago

To avoid an unexpected, unwanted service termination at imagebin.ca, the image uploaded by @usbrandon is image

HiromuHota commented 5 years ago

The issue happens because oldMenu (the one from pentaho-pdi-dataset) stays visible though it is set invisible by https://github.com/HiromuHota/pentaho-kettle/blob/webspoon-8.1/ui/src/main/java/org/pentaho/di/ui/core/ConstUI.java#L269-L272.

HiromuHota commented 5 years ago

The pentaho-pdi-dataset menu is set here https://github.com/mattcasters/pentaho-pdi-dataset/blob/6a58f84cf34cccfe128d3e74085f62342ae841f4/src/main/java/org/pentaho/di/dataset/spoon/xtpoint/ShowUnitTestMenuExtensionPoint.java#L183-L186

HiromuHota commented 5 years ago

Reopen this since I'm experiencing this issue from time to time. There seems to be a race condition, only in RWT, between oldmenu's popup as the control's menu and control.setMenu( menu ) that replaces the control's menu.