Ctrl-Shift-L On Linux

[Hippyjake]

On Linux I can not use the keyboard shortcut. If I remember right, long ago. The original allowed for this but has not for some time. Its also bork in other ways, but you know that ;) So far your fork has fixed all the issues I have had, save the keyboard shortcut. Anything I can do to help Ill jump right in!

[Hirse]

I am on Windows (at least for now) so I didn't test other OS.

I have made a change right now, please have a look if that fixes it for you. If not, please check the Developer Tools Console for any KeyBinding errors.

[Hippyjake]

After some testing I assume the fix works, but is conflicting with "split section into lines" in the edit menu. This is a default keybinding. The stable version does not throw the conflicting error.

Thanks for your quick response.

[Hirse]

On Windows that is Ctrl+Alt+L, so there is no conflict for me. Should I use a different key binding for Linux then?

[Hippyjake]

And the winning combo is

    var keyBindings = [
        {
            key: 'Ctrl-Shift-L',
            platform: 'win'
        }, {
            key: 'Cmd-Shift-L',
            platform: 'mac'
        }, {
            key: 'Ctrl-Alt-L'
        }
    ];

Thank you!

[Hippyjake]

On second thought. I just hope that wont lock peoples desktop sessions, some might. "Ctrl-Alt-B" Might be a good alternative

[Hirse]

Yes, that seems to be the case. I think I will go with

var keyBindings = [
        {
            key: 'Ctrl-Shift-L',
            platform: 'win'
        }, {
            key: 'Ctrl-Alt-B',
            platform: 'win'
        }, {
            key: 'Cmd-Shift-L',
            platform: 'mac'
        }, {
            key: 'Ctrl-Alt-B'
        }
    ];

for now, therefore giving Windows user the choice.

And finally, you could still overwrite that in your user-key-mapping.

[Hippyjake]

Awesome thank you so much!

[Hirse]

I have released a new version, could you make sure it works for you?

[Hippyjake]

All good here