search

Hirse / brackets-outline-list

Extension for Brackets and Phoenix to display a list of the functions or definitions in the currently opened document.
MIT License
79 stars 30 forks source link

javascript //region #45

Closed BernsteinA closed 8 years ago

Hirse commented 8 years ago

Thanks for your PR. Some questions before I merge though: What does //region mean? Why does your PR change the whole JavaScript.js and style.css files?

BernsteinA commented 8 years ago

//region is for organising and folding sections of code.

Not sure why it appears to change the whole files. Line endings maybe. What diff tool are you using?

On Sat, 3 Oct 2015 10:55 Jan Pilzer notifications@github.com wrote:

Thanks for your PR. Some questions before I merge though: What does //region mean? Why does your PR change the whole JavaScript.js and style.css files?

— Reply to this email directly or view it on GitHub https://github.com/Hirse/brackets-outline-list/pull/45#issuecomment-145254518 .

Hirse commented 8 years ago

Just looking at it in GitHub.

BernsteinA commented 8 years ago

close this PR and I'll clean my repo up; will submit a new PR with more sane looking differences

Hirse commented 8 years ago

Thanks. Please also include a short description of Haxe as I never heard of it. ;)

BernsteinA commented 8 years ago

@Hirse http://haxe.org/ https://github.com/HaxeFoundation/haxe

Hirse commented 8 years ago

Alright, could you include a test file in your PR? See the test folder with files for Python etc.