search

Hirse / brackets-outline-list

Extension for Brackets and Phoenix to display a list of the functions or definitions in the currently opened document.
MIT License
79 stars 30 forks source link

PHP Abstract Classes (fix #76) #77

Closed pelatx closed 7 years ago

pelatx commented 7 years ago

Fixed PHP abstract classes support (#76). Fixed PHP extended classes support. Fixed support for PHP anonymous functions within other functions. Fixed support for numbers in PHP class, function and variable names. Fixed PHP static functions not appearing pointed

pelatx commented 7 years ago

Sorry for the disorganized and badly named commits. It's my first PR. I've fixed support for extended classes, maybe in a slightly aggressive way.

Hirse commented 7 years ago

Thanks for this PR. Don't worry about the organization.

Hirse commented 7 years ago

I have added a few test cases for the new features. Could you please have a look if I missed anything?

Additionally, you inheritance implementation seems to have issues when classes implement multiple interfaces. I have added a (disabled) test case and example code. Currently it shows Child::IChild2::speak() where it should be Child::speak(). If you feel like it, I would be very grateful, if you could check that too.

And thanks again for the contribution. 👍

pelatx commented 7 years ago

Of course. I'll look it. Sorry for failing to provide test cases, I'm not very familiar with Javascript tools.

About the inheritance implementation, I realized it a few days ago, plus some other things. I will try to solve as many as I can and send you the changes.

No problem, I'm glad if I can help a little. Thank YOU for your great work in this extension.

Hirse commented 7 years ago

Don't worry about the missing test cases. I have to do some work too, right? 😉

Great. Looking forward to your next PR.