Hirse / brackets-ungit

Brackets Extension to view Ungit directly in Brackets
MIT License
22 stars 5 forks source link

Problem running npm on initial install #5

Open stumblingmages opened 9 years ago

stumblingmages commented 9 years ago

Not issue as much as FYI.

I had a problem installing this initially because the extension couldn't find my npm and node commands. The prompt shown indicated it was attempting a bash command. My default shell is zsh (ohmyzsh to be specific) so all my path config is there.

I did check that when switching to bash, the node and npm executables were found.

Following the tip for manually installing in https://github.com/Hirse/brackets-ungit/issues/2, I was able to run the npm install from the shell and things seem to work ok now.

Running Brackets 1.4 on very latest Mac OS X 10.10.5. Installed npm and node are 1.4.28 and v0.10.40 respectively.

Hirse commented 9 years ago

The self-installer is executing npm install from the Brackets Node process like this:

childProcess.exec("npm install", {
        cwd: __dirname
});

(See npmDomain.js for more.) Admittedly I only tested with CMD and (Git-) Bash on Windows, but I didn't think it would cause any problems on other systems. If you have a solution how to support your use-case, please let me know.

stumblingmages commented 9 years ago

Sorry but I don't have a solution. I just figured this would make a future reference for people searching on similar.