Hirwacardinalloic
commented
2 years ago i tried to change the button but i don't know why if the problem is a img , alt name or what
try to help me if i fail thias one i have to repeat
On Sat, Jul 16, 2022 at 6:52 PM Kandy Peter Kamuntu < @.***> wrote:
@.**** requested changes on this pull request.
Hi @Hirwacardinalloic https://github.com/Hirwacardinalloic,
Good job so far! I know you have worked hard on implementing the changes required by the previous reviewer. However, there is an issue that you still need to work on to go to the next project but you are almost there! To highlight 🍾
- All linters are passing ✔️
- You are following GitHub actions ✔️
Required Changes ♻️
- Kindly check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/Hirwacardinalloic/PORTFOLIO/pull/7#discussion_r922699137 :
Skills
- As suggested by the previous reviewer, it would be better If you use correct links to display your arrow images.
Hint: Your arrow icons have as name Arrow.png and in your code, you called arrow. You can just use replace it with <img src="images/Arrow.png" alt="arrow_bottom" /> to solve the issue
In index.html https://github.com/Hirwacardinalloic/PORTFOLIO/pull/7#discussion_r922699435 :
Hirwacardinalloic
commented
2 years ago all module
On Sat, Jul 16, 2022 at 8:17 PM Hirwa Cardinal Loic < @.***> wrote:
i tried to change the button but i don't know why if the problem is a img , alt name or what
try to help me if i fail thias one i have to repeat
On Sat, Jul 16, 2022 at 6:52 PM Kandy Peter Kamuntu < @.***> wrote:
@.**** requested changes on this pull request.
Hi @Hirwacardinalloic https://github.com/Hirwacardinalloic,
Good job so far! I know you have worked hard on implementing the changes required by the previous reviewer. However, there is an issue that you still need to work on to go to the next project but you are almost there! To highlight 🍾
- All linters are passing ✔️
- You are following GitHub actions ✔️
Required Changes ♻️
- Kindly check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
In index.html https://github.com/Hirwacardinalloic/PORTFOLIO/pull/7#discussion_r922699137 :
Skills
- As suggested by the previous reviewer, it would be better If you use correct links to display your arrow images.
Hint: Your arrow icons have as name Arrow.png and in your code, you called arrow. You can just use replace it with <img src="images/Arrow.png" alt="arrow_bottom" /> to solve the issue
In index.html https://github.com/Hirwacardinalloic/PORTFOLIO/pull/7#discussion_r922699435 :
Kandy-Peter
commented
2 years ago Hello @Hirwacardinalloic, I can assist you. What if we make a zoom call? This is my mail: kandypeter03@gmail.com
Description
In this PR, we create a Responsive Desktop version .
General requirements
Project requirements, We:
[x] Added a responsive Desktop Version with html, css and media queries
Happy reviewing 😃