Histidine91 / Nexerelin

The Nexerelin 4x mod for Starsector.
64 stars 15 forks source link

Crash with Random Core Worlds and Devmode #75

Closed ArdrynSA closed 3 weeks ago

ArdrynSA commented 3 weeks ago

Using Nexerelin 11.2c. Doesn't seem to matter if any other mods beyond prereq mods are active. Guaranteed crash on pressing M while sitting in space and devmode is enabled. Just to be certain, deleted Magic, Lazy, and Nex, and redownloaded them. Also tried fresh 97a-RC11 install. Log file attached. starsector.log

Histidine91 commented 3 weeks ago

Devmode M is a vanilla function (creates a derelict ship with a large amount of rare loot).

I recall Alex saying before that devmode isn't supported for normal play, so he's unlikely to change it. The specific crash is at least a one-line fix (the code in question does a check for Jangala that isn't used anywhere), but later in the code it also tries to create player contacts on a bunch of planets by name, which will break when those markets don't exist.

...well, we could use a modified version of the Jangala check to decide whether to add the contacts, it's just a few lines. Maybe Alex will do it if asked.