search

History-Research-Environment / HRE--History-Research-Environment

Main repo for HRE code
https://historyresearchenvironment.org/
GNU Affero General Public License v3.0
32 stars 6 forks source link

DDL Defects #9

Closed MichaelErichsen closed 6 years ago

MichaelErichsen commented 6 years ago

Three tables are without primary keys: CITN_TYPE_DEFNS SUBSET_PAIR_DEFNS SUBSET_SINGLE_DEFNS Is that intentional or a defect?

HREferg commented 6 years ago

Fixed in DDL v8d reloaded 2018-04-02 (I think)

MichaelErichsen commented 6 years ago

A few defects in the new upload:

Extra commas:

-- Table 353 CREATE TABLE SUBSET_SINGLE_DEFNS (
RECORD_NUM INTEGER NOT NULL, SET_KEY SMALLINT NOT NULL, COMMIT_PID INTEGER NOT NULL, SUBSET_SINGLE_DEFN_PID INTEGER NOT NULL, SUBSET_PID INTEGER, USE_ORDER INTEGER, REFER_PID INTEGER, COUNT INTEGER, );

-- Table 354 CREATE TABLE SUBSET_PAIR_DEFNS (
RECORD_NUM INTEGER NOT NULL, SET_KEY SMALLINT NOT NULL, COMMIT_PID INTEGER NOT NULL, SUBSET_PAIR_PID INTEGER NOT NULL, SUBSET_PID INTEGER, USE_ORDER INTEGER, REFER1_PID INTEGER, REFER2_PID INTEGER, );

Missing semicolon: ALTER TABLE SUBSET_PAIR_DEFNS ADD PRIMARY KEY (RECORD_NUM)

HREferg commented 6 years ago

Now corrected in DDL v8e 2018-04-05