HistoryAtState / frus

Foreign Relations of the United States - TEI XML source files
https://history.state.gov/historicaldocuments
35 stars 14 forks source link

Review frus1977-80v01 #20

Open joewiz opened 8 years ago

joewiz commented 8 years ago

From @cozensef on May 11, 2015 14:4

Copied from original issue: joewiz/frus-tei#64

joewiz commented 8 years ago

From @cozensef on May 11, 2015 14:46

RelaxNG: changed 5 examples of gap/@extent to gap@quantity Schematron: Invalid ref/@target='1977-80v06#d5' Invalid ref/@target="1969-76v14#d227"

-Fixed an invalid ref that had double tagging.

-changed ref target="frus1969-76v38#d9" to ref target="frus1969-76v38p1#d9"

-ref/@target='#d60fn4' was incorrectly tagged (no fn 4). belonged to following ref, so I fixed it.

-persName corresp="#pHAA"> missing part of the tag. Fixed to persName corresp="#p_HAA_1">

-gloss target="#t_PLO_1.", gloss target="#t_OAS_1." , : removed the '.'

-ref target="comp1" : added '#'

-fixed an example of "frus1977-80v1" to "frus1977-80v01"

joewiz commented 8 years ago

From @cozensef on May 11, 2015 17:25

Preface: -fixed signature line on the "About the Series" -Took out ref in section header in the Preface. -centered the section head in the sources section. -added a cross ref to the persons list

joewiz commented 8 years ago

From @cozensef on May 12, 2015 15:10

Sample: Docs #1-5: looked clean. Docs #49-56: in doc #55, 2 incorrectly formatted lists, fixed. Docs #105-110: in doc 106 added href to FRUS cross reference. added list formatting in doc 107. Docs #159-163: in doc 162, fixed a bunch of incorrectly formatted lists.

Misc: page images no longer show up starting with page 700.

joewiz commented 8 years ago

I just checked the permissions on the page images, and they should be accessible. If you can see this, the page images should be working: http://static.history.state.gov.s3.amazonaws.com/frus/frus1977-80v01/medium/0700.png. Could you try again and let me know what you're seeing? (Screenshots work great in GitHub issues :)

joewiz commented 8 years ago

From @cozensef on May 12, 2015 15:51

Hi, Joe! Stephanie and I figured out what the problem is – all the page images have not been uploaded to S3. We are working on it now!

From: Joe Wicentowski [mailto:notifications@github.com] Sent: Tuesday, May 12, 2015 11:44 AM To: joewiz/frus-tei Cc: Cozens, Erin F Subject: Re: [frus-tei] Review frus1977-80v01 (#64)

I just checked the permissions on the page images, and they should be accessible. If you can see this, the page images should be working: http://static.history.state.gov.s3.amazonaws.com/frus/frus1977-80v01/medium/0700.png. Could you try again and let me know what you're seeing? (Screenshots work great in GitHub issues :)

— Reply to this email directly or view it on GitHubhttps://github.com/joewiz/frus-tei/issues/64#issuecomment-101325292.

joewiz commented 8 years ago

Oh good!