HistoryAtState / hsg-shell

Source code for the history.state.gov website
https://history.state.gov
9 stars 13 forks source link

Check markup for heading: Two `<h1>` elements in one document #108

Open plutonik-a opened 8 years ago

plutonik-a commented 8 years ago

http://localhost:8080/exist/apps/hsg-shell/historicaldocuments/frus-history/research/production-and-timeliness-data As the screenshots in https://github.com/eXistSolutions/hsg-shell/issues/101 clearly show, there is a difference between the top heading on the original site and the new markup.

There are actually 2 <h1> headings. On the original site, the heading is styled with a small font and red color. Here http://localhost:8080/exist/apps/hsg-shell/milestones/1776-1783 we have a similar heading, but it's marked as <h5>.

1. This is the actual markup:

bug-14-wrong-heading-markup1

2. This is how it should at least look like

bug-14-h1-heading
plutonik-a commented 8 years ago

I tried to add an offset like described in https://github.com/eXistSolutions/hsg-shell/issues/168 <div data-template="frus-history:article" data-template-heading-offset="1"/> to the container with the second <h1> in pages/historicaldocuments/frus-history/research/article.html (line 33 ), but no effect. No offset, still two <h1>.

Is this the right place anyway to add the offset? I couldn't spot the code, where the <h1> is built anywhere else.

plutonik-a commented 8 years ago

@joewiz & @wolfgangmm

I'm a bit stuck here with trying to prevent the TEI heading from being rendered as a second <h1> in http://localhost:8080/exist/apps/hsg-shell/historicaldocuments/frus-history/research/production-and-timeliness-data or any other article in this category. (pages/historicaldocuments/frus-history/research/article.html)

The advice to apply data-template-heading-offset="1" didn't help so far. Any ideas how to apply this correctly?

plutonik-a commented 8 years ago

Additional CSS fixes with https://github.com/eXistSolutions/hsg-shell/commit/89493a5e616f18271fc29394e33c621adf334839