search

HistoryAtState / hsg-shell

Source code for the history.state.gov website
https://history.state.gov
9 stars 13 forks source link

[frus-events] Change unordered list to definition list, or pass class `list-unstyled` to <ul> #160

Open plutonik-a opened 8 years ago

plutonik-a commented 8 years ago

Current: http://localhost:8080/exist/apps/hsg-shell/historicaldocuments/frus-history/events https://history.state.gov/beta/historicaldocuments/frus-history/events

Desired: https://history.state.gov/historicaldocuments/frus-history/events

Files:

I can't find the code, where the markup for the event article is built! The only hint in modules/frus-history-html.xqm line 319 doesn't help me out.

event-list
joewiz commented 8 years ago

The data is stored in https://github.com/HistoryAtState/frus-history/tree/master/events. I'll happily accept PRs if you change the markup.

plutonik-a commented 8 years ago

Oh I see. There are also inline styles in the XML, which should be deleted. It would be best, if the "events".xml only contained the data. So maybe we should put this + writing a template etc. on a list for milestone 2?

joewiz commented 8 years ago

Sure, this sounds like a good plan!